feat: open in explore traces button #335
Open
+145
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
domasx2
reviewed
Feb 20, 2025
domasx2
reviewed
Feb 20, 2025
src/components/OpenInExploreTracesButton/OpenInExploreTracesButton.tsx
Outdated
Show resolved
Hide resolved
|
hmm, spell-check doesn't like word |
adrapereira
requested changes
Feb 21, 2025
| href={href} | ||
| onClick={() => setReturnToPrevious(returnToPreviousSource || 'previous')} | ||
| > | ||
| Open in Traces drilldown |
There was a problem hiding this comment.
Drilldown should be uppercase. It might also be useful to have a prop for this text:
Suggested change
| Open in Traces drilldown | |
| {props.title ?? 'Open in Traces Drilldown'} |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Exposes an OpenInExploreTracesButton component which takes properties and creates a LinkButton with a href to navigate to the Explore Traces app from outside.